Changeset 5145:c1a3ca765154 in roaraudio for libroar/enumdev.c

Timestamp:

10/11/11 13:47:59 (13 years ago)

Author:

phi

Branch:

default

Phase:

public

Message:

• Fixed invalid pointer aliasing in filter code (pr0)
• Fixed remote a local buffer overflow in client to message converter code as well as a remote attackable overflow in message to client converter code (pr0)
• Updated error handling (pr0)

File:

• libroar/enumdev.c (modified) (2 diffs)

libroar/enumdev.c

@@ -337 +337 @@
  int i;
 
- if ( servs == NULL )
-  return -1;
+ if ( servs == NULL ) {
+  roar_err_set(ROAR_ERROR_FAULT);
+  return -1;
+ }
 
  for (i = 0; (c = &(servs[i]))->server != NULL; i++) {
@@ -361 +363 @@
  size_t ret;
 
- if ( servs == NULL )
-  return -1;
+ if ( servs == NULL ) {
+  roar_err_set(ROAR_ERROR_FAULT);
+  return -1;
+ }
 
  for (ret = 0; servs[ret].server != NULL; ret++);