Changeset 5028:bda7085a07b8 in roaraudio for libroar/nnode.c

Timestamp:

05/28/11 11:46:46 (13 years ago)

Author:

phi

Branch:

default

Phase:

public

Message:

fixed some ckport warnings about poissible buffer overflows which are not possible because buffer length is ensured before the call

File:

• libroar/nnode.c (modified) (3 diffs)

libroar/nnode.c

@@ -206 +206 @@
   case ROAR_SOCKET_TYPE_INET:
     roar_mm_strscpy(proto,     "IPv4");
-    sprintf(nodeaddr, "%i.%i.%i.%i",
+    snprintf(nodeaddr, sizeof(nodeaddr), "%i.%i.%i.%i",
                  nnode->addr.inet4[0], nnode->addr.inet4[1],
                  nnode->addr.inet4[2], nnode->addr.inet4[3]
@@ -213 +213 @@
   case ROAR_SOCKET_TYPE_DECNET:
     roar_mm_strscpy(proto,     "DECnet");
-    sprintf(nodeaddr, "%i.%i", nnode->addr.decnet.area, nnode->addr.decnet.node);
+    snprintf(nodeaddr, sizeof(nodeaddr), "%i.%i", nnode->addr.decnet.area, nnode->addr.decnet.node);
    break;
   case ROAR_SOCKET_TYPE_INET6:
@@ -222 +222 @@
    break;
   default:
-    sprintf(proto, "P#%i", nnode->socktype);
+    snprintf(proto, sizeof(proto), "P#%i", nnode->socktype);
    break;
  }