Opened 13 years ago
Closed 13 years ago
#87 closed task (fixed)
roarclients should be converted to use VS if possible
Reported by: | ph3-der-loewe | Owned by: | ph3-der-loewe |
---|---|---|---|
Priority: | minor | Milestone: | RoarAudio major release 0.4 |
Component: | RoarAudio Main Package | Version: | 0.4beta7 |
Keywords: | Cc: | ||
Architecture: | Compiler: | ||
Difficulty: | Kernel: | ||
Operating System: | Parent Tickets: | ||
Patch attached: | no | Protocol: | |
Sound driver: | Topic: | other |
Description
Some of the roarclients can be converted to use VS API. This should be done if possible. This would be good as they may be used as examples by new devels. In fact docs sometimes say they are useful as examples. Upgrading to VS API will show the power of VS in production tools and add new examples to the list. Such an update may in addition improve quality by cleanup and we can write a list of tools needing more cleanup/rewrite.
Subtickets
Change History (5)
comment:1 Changed 13 years ago by ph3-der-loewe
comment:2 Changed 13 years ago by ph3-der-loewe
Tools using VS:
roarfish: vio=0, vs=1
roarshout: vio=1, vs=1
roarsin: vio=0, vs=1
roarvorbis: vio=1, vs=1
Tools not using VS:
roarbidir: vio=0, vs=0
roarcat: vio=1, vs=0
roarcatplay: vio=0, vs=0
roarcatvio: vio=1, vs=0
roardtmf: vio=1, vs=0
roarfilt: vio=1, vs=0
roarinterconnect: vio=1, vs=0
roarmon: vio=1, vs=0
roarmonhttp: vio=1, vs=0
roarphone: vio=1, vs=0
roarradio: vio=0, vs=0
Tools which should be considered:
roarbidir: vio=0, vs=0
roarcat: vio=1, vs=0(?)
roarcatplay: vio=0, vs=0
roarcatvio: vio=1, vs=0
roardtmf: vio=1, vs=0
roarfilt: vio=1, vs=0
roarmon: vio=1, vs=0(?)
roarmonhttp: vio=1, vs=0(?)
roarphone: vio=1, vs=0
comment:3 Changed 13 years ago by ph3-der-loewe
converted roardtmf.
But here is another one:
roarvumeter: vio=1, vs=0
comment:4 Changed 13 years ago by ph3-der-loewe
- Owner set to ph3-der-loewe
- Status changed from new to accepted
Tools which got updated:
roarcatplay: vio=0, vs=0 (can not completely be converted as it uses lower API stuff (for passive mode))
roarcatvio: vio=1, vs=0
roarbidir: vio=0, vs=0
New list of tools which should be considered:
roarfilt: vio=1, vs=0 (code has been written, not yet commited because of unsolved deadlocks)
Stuff that will not be converted:
roarphone: vio=1, vs=0 (uses Jumbo packets)
roarcat: vio=1, vs=0 (uses rel-id)
roarmon: vio=1, vs=0 (uses rel-id)
roarmonhttp: vio=1, vs=0 (uses rel-id)
comment:5 Changed 13 years ago by ph3-der-loewe
- Resolution set to fixed
- Status changed from accepted to closed
- Version changed from current to 0.4beta7
The last one (roarfilt) requires a bigger change in the simple stream API. This is targeted for next soname change. The current implementation will result in dead lock between server and client. To avoid this roard currently only support FILTER streams EXECed.
I close it for this mile stone and added a new ticket for this: #138.
roarsin.c has warnings about IO stuff this will solve.