Changeset 5270:e25346c13638 in roaraudio for libroaryiff

Timestamp:

11/17/11 18:20:12 (12 years ago)

Author:

phi

Branch:

default

Phase:

public

Message:

fixed some gcc -Wextra warnings

Location:

libroaryiff

Files:

• Makefile (modified) (1 diff)
• connection.c (modified) (2 diffs)
• events.c (modified) (1 diff)
• file.c (modified) (1 diff)
• stub.c (modified) (1 diff)

libroaryiff/Makefile

@@ -7 +7 @@
 #DEFINES        = -DDEBUG
 INCLUDE = -I../include -I../include/libroaryiff
-CFLAGS += -g -Wall $(OPTI_O) $(DEFINES) $(INCLUDE) $(INCPATH) $(SHARED_CF) $(fPIC)
-LDFLAGS+= -g $(SHARED) $(LDPATH) -L../lib/
+CFLAGS += -g -Wall $(Wextra) $(OPTI_O) $(DEFINES) $(INCLUDE) $(INCPATH) $(SHARED_CF) $(fPIC)
+LDFLAGS+= -g -Wall $(Wextra) $(SHARED) $(LDPATH) -L../lib/
 LIBS    = $(LIBROAR)
 

libroaryiff/connection.c

@@ -39 +39 @@
  YConnection * ycon = roar_mm_malloc(sizeof(YConnection));
  struct roar_connection con;
- char * server = (char *)con_arg;
- char * name   = "libroaryiff client";
+ const char * server = (char *)con_arg;
+ const char * name   = "libroaryiff client";
 
  memset(ycon, 0, sizeof(YConnection));
@@ -75 +75 @@
  struct roar_vio_calls vio;
 
+ // in case we started the server by using +fork we can not keep it running
+ // as it will terminate anyway. If there are any other clients (I guess
+ // this is what this option is about) it will keep running.
+ (void)no_shutdown;
+
  if ( connection == NULL )
   return;

libroaryiff/events.c

@@ -37 +37 @@
 
 // RoarAudio isn't event based, so we need to trick a lot here
+// Maybe this can be overcome with the notify API
 
 int YGetNextEvent (YConnection *con, YEvent *event, Boolean block) {
  struct roar_connection rcon;
  struct roar_stream s;
+
+ (void)block;
 
  if ( con == NULL || event == NULL )

libroaryiff/file.c

@@ -37 +37 @@
 
 int YGetSoundObjectAttributes (YConnection *con, const char *path, YEventSoundObjectAttributes *buf) {
+ (void)con;
+
  if ( buf == NULL )
   return -1;

libroaryiff/stub.c

@@ -38 +38 @@
 // in here only some stub functions are delcared
 
-extern void YSyncAll(YConnection *con, Boolean block) {
+void YSyncAll(YConnection *con, Boolean block) {
+ (void)con, (void)block;
 }