Changeset 5145:c1a3ca765154 in roaraudio for libroar/keyval.c

Timestamp:

10/11/11 13:47:59 (13 years ago)

Author:

phi

Branch:

default

Phase:

public

Message:

• Fixed invalid pointer aliasing in filter code (pr0)
• Fixed remote a local buffer overflow in client to message converter code as well as a remote attackable overflow in message to client converter code (pr0)
• Updated error handling (pr0)

File:

• libroar/keyval.c (modified) (3 diffs)

libroar/keyval.c

@@ -40 +40 @@
  ssize_t i;
 
+ if ( kv == NULL || key == NULL ) {
+  roar_err_set(ROAR_ERROR_FAULT);
+  return NULL;
+ }
+
  if ( casesens )
   sc = strcmp;
@@ -48 +53 @@
  }
 
+ roar_err_set(ROAR_ERROR_NOENT);
  return NULL;
 }
@@ -67 +73 @@
  int last_was_seg = 0;
 
- if ( kv == NULL || str == NULL )
+ if ( kv == NULL || str == NULL ) {
+  roar_err_set(ROAR_ERROR_FAULT);
   return -1;
+ }
 
  // we currently do not support quotes
- if ( quotes )
+ if ( quotes ) {
+  roar_err_set(ROAR_ERROR_NOTSUP);
   return -1;
+ }
 
  if ( fdel == NULL )