Changeset 5028:bda7085a07b8 in roaraudio for libroar/vio_proto.c

Timestamp:

05/28/11 11:46:46 (13 years ago)

Author:

phi

Branch:

default

Phase:

public

Message:

fixed some ckport warnings about poissible buffer overflows which are not possible because buffer length is ensured before the call

File:

• libroar/vio_proto.c (modified) (2 diffs)

libroar/vio_proto.c

@@ -448 +448 @@
   return NULL;
 
- inlen = strlen(up->user) + strlen(up->pass) + 2;
+ inlen = roar_mm_strlen(up->user) + roar_mm_strlen(up->pass) + 2;
  inbuf = roar_mm_malloc(inlen);
  if ( inbuf == NULL )
@@ -454 +454 @@
 
  inbuf[0] = 0;
- strcat(inbuf, up->user);
- strcat(inbuf, ":");
- strcat(inbuf, up->pass);
+ roar_mm_strlcat(inbuf, up->user, inlen);
+ roar_mm_strlcat(inbuf, ":", inlen);
+ roar_mm_strlcat(inbuf, up->pass, inlen);
 
  outlen = ((inlen * 3) / 2) + 3 /* padding... */ + 6 /* 'Basic ' */;