Changeset 5098:49d6eb21d70e in roaraudio for libroar

Timestamp:

07/23/11 13:27:26 (13 years ago)

Author:

phi

Branch:

default

Phase:

public

Message:

warn about numerical hostnames for IP

File:

• libroar/socket.c (modified) (2 diffs)

libroar/socket.c

@@ -535 +535 @@
  char port_as_string[32];
 #endif
+#if defined(ROAR_HAVE_IPV4) || defined(ROAR_HAVE_IPV6)
+ int is_numerical = 1;
+ const char * numptr;
+#endif
 
  ROAR_DBG("roar_socket_open(mode=%i, type=%i, host='%s', port=%i) = ?", mode, type, host, port);
@@ -620 +624 @@
 
   ROAR_DBG("roar_socket_open(*): type=INET|INET6, host='%s', port=%i", host, port);
+
+  if ( !!strcmp(host, "0.0.0.0") ) {
+   for (numptr = host; is_numerical && *numptr != 0; numptr++)
+    if ( ! ((*numptr >= '0' && *numptr <= '9') || *numptr == '.')  )
+     is_numerical = 0;
+
+   if ( is_numerical ) {
+    ROAR_WARN("roar_socket_open(*): Hostname \"%s\" is numerical. Do not use IP addresses directly. Use Hostnames.", host);
+   }
+  }
 
 #ifdef ROAR_HAVE_GETADDRINFO