Changeset 5132:1c10be48298e in roaraudio

Timestamp:

09/09/11 16:24:15 (12 years ago)

Author:

phi

Branch:

default

Phase:

public

Message:

Fixed invalid pointer aliasing (Closes: #178)

Files:

• ChangeLog (modified) (1 diff)
• libroar/basic.c (modified) (2 diffs)

ChangeLog

@@ -1 +1 @@
 v. 0.4rc1 - ?
         * Fixed segfaul in FLAC cf (Closes: #177)
+        * Fixed invalid pointer aliasing (Closes: #178)
 
 v. 0.4rc0 - Mon Sep 05 2011 15:25 CEST

libroar/basic.c

@@ -393 +393 @@
 int roar_identify   (struct roar_connection * con, const char * name) {
  struct roar_message mes;
- pid_t pid;
+ uint32_t pid;
  int max_len;
 
@@ -423 +423 @@
 
  pid = getpid();
- *(uint32_t*)(mes.data+1) = ROAR_HOST2NET32(pid);
- ROAR_DBG("roar_identify(*): pid = %i", pid);
+ mes.data[1] = (pid & 0xFF000000UL) >> 24;
+ mes.data[2] = (pid & 0x00FF0000UL) >> 16;
+ mes.data[3] = (pid & 0x0000FF00UL) >>  8;
+ mes.data[4] = (pid & 0x000000FFUL) >>  0;
+ ROAR_DBG("roar_identify(*): pid = %i", (int)pid);
 
  strncpy(mes.data+5, name, max_len);