Opened 12 years ago

Closed 12 years ago

#293 closed defect (fixed)

pa_xfree() needs return getting fixed.

Reported by: ph3-der-loewe Owned by: ph3-der-loewe
Priority: wishlist Milestone: RoarAudio major release 1.0
Component: libroar and friends Version: 1.0beta5
Keywords: libroarpulse Cc:
Architecture: Compiler:
Difficulty: very easy Kernel:
Operating System: Parent Tickets:
Patch attached: yes Protocol:
Sound driver: Topic: Bug Fix

Description

pa_xfree() is of type void and should not return a value. This should be fixed.

The following patch will do this:

  • xmalloc.c 

    diff -u -r1.5 xmalloc.c
     
    6363 
    6464/** Free allocated memory */ 
    6565void pa_xfree(void *p) { 
    66  return roar_mm_free(p); 
     66 roar_mm_free(p); 
    6767} 
    6868 
    6969/** Duplicate the specified string, allocating memory with pa_xmalloc() */ 

Subtickets

Change History (2)

comment:1 Changed 12 years ago by ph3-der-loewe

  • Owner set to ph3-der-loewe
  • Status changed from new to accepted

comment:2 Changed 12 years ago by ph3-der-loewe

  • Resolution set to fixed
  • Status changed from accepted to closed
  • Version changed from current to 1.0beta5
Note: See TracTickets for help on using tickets.