Opened 9 years ago

Closed 9 years ago

#137 closed defect (fixed)

midi_conv_midi2mes() needs to be re-written

Reported by: ph3-der-loewe Owned by: ph3-der-loewe
Priority: critical Milestone: RoarAudio major release 0.4
Component: roard Version: 0.4rc0
Keywords: midi Cc:
Architecture: Compiler:
Difficulty: Kernel:
Operating System: Parent Tickets:
Patch attached: no Protocol:
Sound driver: Topic: Bug Fix

Description

midi_conv_midi2mes() is the function doing the endless loop in case buffers aren't nicely aligned and nicely filled with data resulting in roard hanging in endless loop.

The function currently does some very stupid stuff like reading one byte from a one byte buffer, detects that it needs two bytes, puts the byte back and then restarts the process.

The function should be re-written completely.

Subtickets

Change History (2)

comment:1 Changed 9 years ago by ph3-der-loewe

  • Priority changed from major to critical

Upgrading prio to critical as it crashs roard sometimes.

comment:2 Changed 9 years ago by ph3-der-loewe

  • Resolution set to fixed
  • Status changed from new to closed
  • Version changed from current to 0.4beta8

The code as been re-written.

The old code is still in roard ('#if 0'ed) and should be removed by the next release. It is left there so if there is still any problem it is more easy to fix.

Note: See TracTickets for help on using tickets.