Changeset 5270:e25346c13638 in roaraudio for roarfish

Timestamp:

11/17/11 18:20:12 (12 years ago)

Author:

phi

Branch:

default

Phase:

public

Message:

fixed some gcc -Wextra warnings

Location:

roarfish

Files:

• Makefile (modified) (1 diff)
• include/roarfish.h (modified) (1 diff)
• play.c (modified) (2 diffs)

roarfish/Makefile

@@ -8 +8 @@
 #DEFINES        = -DDEBUG
 INCLUDE = -I../include -I./include
-CFLAGS += -g -Wall $(OPTI_O) $(DEFINES) $(INCLUDE) $(INCPATH)
-LDFLAGS+= -g -L../lib/ $(LDPATH)
+CFLAGS += -g -Wall $(Wextra) $(OPTI_O) $(DEFINES) $(INCLUDE) $(INCPATH)
+LDFLAGS+= -g -Wall $(Wextra) -L../lib/ $(LDPATH)
 LIBS    = $(LIBROAR) $(lib_fishsound) $(lib_oggz)
 

roarfish/include/roarfish.h

@@ -42 +42 @@
 #include <sndfile.h>
 
-int play (char * file, char ** opts);
+int play (const char * file, char ** opts);
 
 #ifdef __USE_SVID

roarfish/play.c

@@ -63 +63 @@
 
 
- roar_vs_write(inst->vss, (char*)data, frames * 2, NULL);
+ if ( roar_vs_write(inst->vss, (char*)data, frames * 2, NULL) != (ssize_t)(frames * 2) ) {
+  return -1;
+ }
 
 
@@ -74 +76 @@
  FishSound * fsound = (FishSound *)user_data;
 
- fish_sound_prepare_truncation (fsound, op->granulepos, op->e_o_s);
- fish_sound_decode (fsound, op->packet, op->bytes);
+ (void)oggz, (void)serialno;
+
+ fish_sound_prepare_truncation(fsound, op->granulepos, op->e_o_s);
+ fish_sound_decode(fsound, op->packet, op->bytes);
 
  return 0;
 }
 
-int play (char * file, char ** opts) {
+int play (const char * file, char ** opts) {
  OGGZ * oggz;
  struct roarfish_play_inst inst;
+
+ (void)opts;
 
  inst.vss    = NULL;