Changeset 5754:b23d79c13370 in roaraudio for roarclients

Timestamp:

11/16/12 16:49:56 (11 years ago)

Author:

phi

Branch:

default

Phase:

public

Message:

avoid getenv() and use more portable roar_env_get(). Also improved security as we enfore const now on bufferes obtained from the env.

File:

• roarclients/roarmonhttp.c (modified) (3 diffs)

roarclients/roarmonhttp.c

@@ -239 +239 @@
  int    i;
  const char * k, * v;
+ const char * qs;
+ char * qs_buf;
  char * c;
  char * sp0 = NULL, * sp1 = NULL;
@@ -292 +294 @@
  }
 
- c = getenv("QUERY_STRING");
+ qs = roar_env_get("QUERY_STRING");
+ if ( qs == NULL )
+  qs = "";
+ c = qs_buf = roar_mm_strdup(qs);
  if ( c == NULL )
-  c = "";
+  return 1;
 
  c = roar_mm_strtok_r(c, "&", &sp0);
@@ -336 +341 @@
  }
 
+ roar_mm_free(qs_buf);
+
  if ( roar_simple_connect(&con, server, "roarmonhttp") == -1 ) {
   return 10;