Changeset 5754:b23d79c13370 in roaraudio for libroaross

Timestamp:

11/16/12 16:49:56 (11 years ago)

Author:

phi

Branch:

default

Phase:

public

Message:

avoid getenv() and use more portable roar_env_get(). Also improved security as we enfore const now on bufferes obtained from the env.

File:

• libroaross/libroaross.c (modified) (3 diffs)

libroaross/libroaross.c

@@ -382 +382 @@
 }
 
-static struct session * _open_session (char * server, char * name) {
+static struct session * _open_session (const char * server, const char * name) {
  struct session * ses = &_session;
- int new_session = getenv("ROAR_OSS_NEW_SESSION") == NULL ? 0 : 1;
+ int new_session = roar_env_get("ROAR_OSS_NEW_SESSION") == NULL ? 0 : 1;
 
  ROAR_DBG("_open_session(server='%s', name='%s') = ?", server, name);
@@ -400 +400 @@
 
   if ( name == NULL )
-   name = getenv("ROAR_OSS_CLIENT_NAME");
+   name = roar_env_get("ROAR_OSS_CLIENT_NAME");
 
   if ( name == NULL )
@@ -415 +415 @@
 
   if ( !new_session ) {
-   if ( getenv("ROAR_OSS_KEEP_SESSION") != NULL )
+   if ( roar_env_get("ROAR_OSS_KEEP_SESSION") != NULL )
     ses->refc++;
   }