Changeset 5754:b23d79c13370 in roaraudio for libroar/pinentry.c

Timestamp:

11/16/12 16:49:56 (11 years ago)

Author:

phi

Branch:

default

Phase:

public

Message:

avoid getenv() and use more portable roar_env_get(). Also improved security as we enfore const now on bufferes obtained from the env.

File:

• libroar/pinentry.c (modified) (3 diffs)

libroar/pinentry.c

@@ -45 +45 @@
 #endif
 
-int roar_pinentry_open (struct roar_pinentry * pe, int flags, char * display, char * tty, char * term) {
+int roar_pinentry_open (struct roar_pinentry * pe, int flags, const char * display, const char * tty, const char * term) {
 #ifdef _CAN_OPERATE
  int in[2], out[2];
@@ -57 +57 @@
 
  if ( display == NULL )
-  display = getenv("DISPLAY");
+  display = roar_env_get("DISPLAY");
 
  if ( display == NULL )
@@ -73 +73 @@
 
  if ( term == NULL )
-  term = getenv("TERM");
+  term = roar_env_get("TERM");
 
  if ( term == NULL )