Changeset 3875:8731d0c3e04a in roaraudio

Timestamp:

05/21/10 10:50:48 (14 years ago)

Author:

phi

Branch:

default

Phase:

public

Message:

init/zero messages with memset()

Files:

• libroar/basic.c (modified) (2 diffs)
• libroar/client.c (modified) (1 diff)
• libroar/meta.c (modified) (2 diffs)
• libroar/stream.c (modified) (10 diffs)
• libroaresd/esdbasic.c (modified) (2 diffs)
• libroaresd/esdctl.c (modified) (1 diff)
• roarclients/roarctl.c (modified) (1 diff)

libroar/basic.c

@@ -281 +281 @@
  struct roar_message m;
 
+ memset(&m, 0, sizeof(m));
+
  m.datalen = 0;
  m.stream  = 0;
@@ -321 +323 @@
 
  ROAR_DBG("roar_identify(*): try to identify myself...");
+
+ memset(&mes, 0, sizeof(mes));
 
  mes.cmd    = ROAR_CMD_IDENTIFY;

libroar/client.c

@@ -94 +94 @@
  int i;
 
+ memset(&m,  0, sizeof(m));
+
  m.cmd     = ROAR_CMD_PASSFH;
  m.stream  =  -1; // client (non-stream) passs

libroar/meta.c

@@ -468 +468 @@
  char * c;
 
+ memset(&m,  0, sizeof(m));
+
  m.cmd     = ROAR_CMD_GET_META;
  m.stream  = s->id;
@@ -503 +505 @@
  int i;
  struct roar_message m;
+
+ memset(&m,  0, sizeof(m));
 
  m.cmd     = ROAR_CMD_LIST_META;

libroar/stream.c

@@ -43 +43 @@
  s->dir = dir;
 
+ memset(&m,  0, sizeof(m));
  memcpy(&ms, s, sizeof(ms));
 
@@ -194 +195 @@
  struct roar_message m;
 
+ memset(&m,  0, sizeof(m));
+
  m.cmd     = ROAR_CMD_EXEC_STREAM;
  m.stream  = s->id;
@@ -230 +233 @@
  ROAR_DBG("roar_stream_connect_to_ask(*): Ask the server to connect to: %s:%i", host, port);
 
+ memset(&m,  0, sizeof(m));
+
  m.cmd     = ROAR_CMD_CON_STREAM;
  m.stream  = s->id;
@@ -256 +261 @@
  struct roar_message m;
  int confh;
+
+ memset(&m,  0, sizeof(m));
 
  m.cmd     = ROAR_CMD_PASSFH;
@@ -299 +306 @@
  int i;
 
+ memset(&m,  0, sizeof(m));
+
  m.cmd     = ROAR_CMD_ATTACH;
  m.stream  = s->id;
@@ -324 +333 @@
  struct roar_message m;
 
+ memset(&m,  0, sizeof(m));
+
  m.cmd     = ROAR_CMD_ADD_DATA;
  m.stream  = s->id;
@@ -370 +381 @@
  uint16_t * data = (uint16_t *) m.data;
  int i;
+
+ memset(&m,  0, sizeof(m));
 
  m.cmd     = ROAR_CMD_GET_STREAM_PARA;
@@ -447 +460 @@
  name[0] = 0; // just in case...
 
+ memset(&m,  0, sizeof(m));
+
  m.cmd     = ROAR_CMD_GET_STREAM_PARA;
  m.stream  = s->id;
@@ -600 +615 @@
  int i;
 
+ memset(&m,  0, sizeof(m));
+
  m.cmd     = ROAR_CMD_SET_STREAM_PARA;
  m.stream  = s->id;
@@ -627 +644 @@
  uint16_t * data = (uint16_t *) m.data;
  int i;
+
+ memset(&m,  0, sizeof(m));
 
  m.cmd     = ROAR_CMD_SET_STREAM_PARA;

libroaresd/esdbasic.c

@@ -81 +81 @@
 /* if your stream is at 22.05 Khz it'll be double this - in mono   */
 /* double again ... etc.                                           */
+
+// TODO: FIXME: write something usefull here.
 int esd_get_latency(int esd) {
 #ifdef ROAR_HAVE_GETTIMEOFDAY
@@ -86 +88 @@
  struct roar_message    m;
  struct roar_connection con;
+
+ memset(&m, 0, sizeof(m));
 
  m.cmd = ROAR_CMD_NOOP;

libroaresd/esdctl.c

@@ -150 +150 @@
 
  roar_connect_fh(&con, esd);
+
+ memset(&m, 0, sizeof(m));
+
  m.cmd     = ROAR_CMD_SERVER_OINFO;
  m.datalen = 0;

roarclients/roarctl.c

@@ -125 +125 @@
 
  for (i = 0; i < num; i++) {
+  memset(&m, 0, sizeof(m));
+
   m.cmd = ROAR_CMD_NOOP;
   m.datalen = 0;
+
+  // we use roar_req() directly here because of speed.
+  // roar_noop() does basicly the same but is a bit slower.
 
   gettimeofday(&try, NULL);