Changeset 4049:802580eeb8a8 in roaraudio

Timestamp:

07/09/10 15:46:06 (14 years ago)

Author:

phi

Branch:

default

Phase:

public

Message:

fixed security warnings

Files:

• plugins/roard/protocol-rplay.c (modified) (1 diff)
• roard/meta.c (modified) (2 diffs)
• roard/roard.c (modified) (1 diff)

plugins/roard/protocol-rplay.c

@@ -219 +219 @@
  s -= m * 60;
 
- sprintf(uptime, "%.2i:%.2i:%.2i", h, m, s);
+ snprintf(uptime, sizeof(uptime)-1, "%.2i:%.2i:%.2i", h, m, s);
+ uptime[sizeof(uptime)-1] = 0;
 
  switch (ROAR_CODEC_BYTE_ORDER(g_sa->codec)) {

roard/meta.c

@@ -64 +64 @@
    }
 
-   if ( (c = malloc(strlen(val)+1)) == NULL ) {
+   if ( (c = strdup(val)) == NULL ) {
     s->meta[i].type = ROAR_META_TYPE_NONE;
     s->meta[i].key[0] = 0;
@@ -70 +70 @@
    }
 
-   strcpy(c, val);
    s->meta[i].value = c;
 

roard/roard.c

@@ -444 +444 @@
 
   if ( p->port ) {
-   sprintf(port, "%i", p->port);
+   snprintf(port, sizeof(port)-1, "%i", p->port);
+   port[sizeof(port)-1] = 0;
   } else {
    strcpy(port, "(none)");